FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.2.1

Threshold is Low

Effort is Default

Summary

Classes Bugs Errors Missing Classes
308 27 0 0

Files

Class Bugs
org.sat4j.core.Vec 3
org.sat4j.core.VecInt 5
org.sat4j.minisat.constraints.cnf.Lits 1
org.sat4j.minisat.core.Heap 1
org.sat4j.minisat.core.Pair 1
org.sat4j.minisat.core.Solver 4
org.sat4j.minisat.learning.AbstractLearning 1
org.sat4j.minisat.learning.LimitedLearning 1
org.sat4j.minisat.learning.MiniSATLearning 1
org.sat4j.opt.AbstractSelectorVariablesDecorator 1
org.sat4j.opt.MaxSatDecorator 1
org.sat4j.opt.MinOneDecorator 3
org.sat4j.reader.EfficientScanner 1
org.sat4j.reader.LecteurDimacs 1
org.sat4j.tools.xplain.Pair 2

org.sat4j.core.Vec

Bug Category Details Line
Unchecked/unconfirmed cast from org.sat4j.specs.IVec to org.sat4j.core.Vec in org.sat4j.core.Vec.copyTo(IVec) STYLE BC_UNCONFIRMED_CAST 287
org.sat4j.core.Vec.toArray() may expose internal representation by returning Vec.myarray MALICIOUS_CODE EI_EXPOSE_REP 319
org.sat4j.core.Vec.Vec(Object[]) may expose internal representation by storing an externally mutable object into Vec.myarray MALICIOUS_CODE EI_EXPOSE_REP2 87

org.sat4j.core.VecInt

Bug Category Details Line
Unchecked/unconfirmed cast from org.sat4j.specs.IVecInt to org.sat4j.core.VecInt in org.sat4j.core.VecInt.copyTo(IVecInt) STYLE BC_UNCONFIRMED_CAST 329
Unchecked/unconfirmed cast from org.sat4j.specs.IVecInt to org.sat4j.core.VecInt in org.sat4j.core.VecInt.moveTo2(IVecInt) STYLE BC_UNCONFIRMED_CAST 353
Unchecked/unconfirmed cast from org.sat4j.specs.IVecInt to org.sat4j.core.VecInt in org.sat4j.core.VecInt.pushAll(IVecInt) STYLE BC_UNCONFIRMED_CAST 565
org.sat4j.core.VecInt.toArray() may expose internal representation by returning VecInt.myarray MALICIOUS_CODE EI_EXPOSE_REP 618
org.sat4j.core.VecInt.VecInt(int[]) may expose internal representation by storing an externally mutable object into VecInt.myarray MALICIOUS_CODE EI_EXPOSE_REP2 200

org.sat4j.minisat.constraints.cnf.Lits

Bug Category Details Line
Class org.sat4j.minisat.constraints.cnf.Lits defines non-transient non-serializable instance field reason BAD_PRACTICE SE_BAD_FIELD Not available

org.sat4j.minisat.core.Heap

Bug Category Details Line
org.sat4j.minisat.core.Heap.Heap(double[]) may expose internal representation by storing an externally mutable object into Heap.activity MALICIOUS_CODE EI_EXPOSE_REP2 103

org.sat4j.minisat.core.Pair

Bug Category Details Line
Class org.sat4j.minisat.core.Pair defines non-transient non-serializable instance field reason BAD_PRACTICE SE_BAD_FIELD Not available

org.sat4j.minisat.core.Solver

Bug Category Details Line
org.sat4j.minisat.core.Solver.reduceDB() forces garbage collection; extremely dubious except in benchmarking code PERFORMANCE DM_GC 978
Should org.sat4j.minisat.core.Solver.findModel() return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 1513
Should org.sat4j.minisat.core.Solver.findModel(IVecInt) return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 1522
Exception is caught when Exception is not thrown in org.sat4j.minisat.core.Solver.setSimplifier(String) STYLE REC_CATCH_EXCEPTION 588

org.sat4j.minisat.learning.AbstractLearning

Bug Category Details Line
AbstractLearning.val not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.sat4j.minisat.learning.LimitedLearning

Bug Category Details Line
LimitedLearning.stats not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.sat4j.minisat.learning.MiniSATLearning

Bug Category Details Line
MiniSATLearning.dsf not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.sat4j.opt.AbstractSelectorVariablesDecorator

Bug Category Details Line
org.sat4j.opt.AbstractSelectorVariablesDecorator.model() may expose internal representation by returning AbstractSelectorVariablesDecorator.prevmodel MALICIOUS_CODE EI_EXPOSE_REP 131

org.sat4j.opt.MaxSatDecorator

Bug Category Details Line
Class org.sat4j.opt.MaxSatDecorator defines non-transient non-serializable instance field prevConstr BAD_PRACTICE SE_BAD_FIELD Not available

org.sat4j.opt.MinOneDecorator

Bug Category Details Line
org.sat4j.opt.MinOneDecorator.model() may expose internal representation by returning MinOneDecorator.prevmodel MALICIOUS_CODE EI_EXPOSE_REP 123
Class org.sat4j.opt.MinOneDecorator defines non-transient non-serializable instance field previousConstr BAD_PRACTICE SE_BAD_FIELD Not available
MinOneDecorator.prevmodel not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.sat4j.reader.EfficientScanner

Bug Category Details Line
The field org.sat4j.reader.EfficientScanner.in is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available

org.sat4j.reader.LecteurDimacs

Bug Category Details Line
LecteurDimacs.in not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.sat4j.tools.xplain.Pair

Bug Category Details Line
org.sat4j.tools.xplain.Pair defines compareTo(Pair) and uses Object.equals() BAD_PRACTICE EQ_COMPARETO_USE_OBJECT_EQUALS 46-51
Test for floating point equality in org.sat4j.tools.xplain.Pair.compareTo(Pair) STYLE FE_FLOATING_POINT_EQUALITY 48